-
Notifications
You must be signed in to change notification settings - Fork 95
Modernize packaging and fix CI #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pyproject.toml
Outdated
"Environment :: Web Environment", | ||
"Development Status :: 5 - Production/Stable", | ||
] | ||
requires-python = ">=3.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.9 per the changes
While you're at it... (I know, sorry) Would you mind adding Python 3.14 to the build so wheels for 3.14 get uploaded once this has been merged and released? At this time there's only 3.13 |
Sure! I was planning to do that in a followup but I can do it here just as well. I'll try to get this done this week but I'm traveling and may not have time until next week. |
Actually, on second thought, I'll open a followup with this. I still haven't heard from a project maintainer on this PR and I'm not sure if they're OK with these changes. |
As per-review, this was not updated.
Hi, working with @ngoldbaum, I've updated pyproject.toml to mention 3.9 and increase testing range to 3.14 (which I can also do in a separate PR) |
I believe the Cython build dependency was optional because we package the cythonized I'll work on your PR - which is pretty good already - and get it merged today, hope you don't mind. |
* Updated Makefile, support uv * Pinned setuptools as we use SetupRequirementsError * Updated release workflow * Dropped outdated stuff
Fixes #129
I think these days there's no need to have an optional dependency on Cython. You can declare cython as a build dependency in your
pyproject.toml
and pip or uv will install Cython in the build environment.I make use of that capability to substantially simplify the
setup.py
file.Since creating a
pyproject.toml
file automatically opts into pep 517 isolated builds, I also took the opportunity to move all the static metadata intopyproject.toml
.I probably also need to update the makefile and readme but I didn't want to do that without confirming that this approach is OK with the maintainers.
To get the CI to pass I also had to drop Python 3.8 support. Python 3.8 has been EOL since October 2024.